Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

[GoogleMaps] Simplify ruleset - #11070

Merged
Hainish merged 5 commits into
EFForg:masterfrom
Bisaloo:patch-65
Aug 15, 2017
Merged

Hainish merged 5 commits into
EFForg:masterfrom
Bisaloo:patch-65

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jul 14, 2017

Copy link
Copy Markdown
Collaborator

I know this is important we don't break anything here so please take your time to review. I can also understand if you prefer to keep some more complicated rules for clarity.

<exclusion pattern="^http://maps\.google\.gr/transitathens" />
<test url="http://maps.google.gr/transitathens" />
<test url="http://maps.google.ca/" />
<test url="http://maps.google.com/" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add at least 3 for each wildcard.

@J0WI J0WI added this to the Before the Next Release milestone Jul 21, 2017
@J0WI

J0WI commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

LGTM. Let's ask @jeremyn or @Hainish for an additional review.

@J0WI J0WI added the conflict label Jul 26, 2017
@J0WI

J0WI commented Jul 26, 2017

Copy link
Copy Markdown
Contributor

Oh, this needs to be rebased first.

@Hainish
Hainish merged commit c2e2fdd into EFForg:master Aug 15, 2017
@Bisaloo
Bisaloo deleted the patch-65 branch August 15, 2017 05:04
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants